Skip to content

src: make base64.h self-contained#17177

Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:base64-include-stdint
Closed

src: make base64.h self-contained#17177
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:base64-include-stdint

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Nov 21, 2017

This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Nov 21, 2017
@danbev
src: make base64.h self-contained
0c2682a 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 21, 2017

I am sorry, but unable to follow - by including a new header (that carry some types required in the file which were resolved otherwise through different route) what benefit we foresee to the compilation unit?

@danbev
Copy link
Contributor Author

danbev commented Nov 21, 2017

I am sorry, but unable to follow - by including a new header (that carry some types required in the file which were resolved otherwise through different route) what benefit we foresee to the compilation unit?

One benefit is that making changes to util.h will not affect base64.h, so the types that are used by this header are also included by it. Google's C++ Style Guide has some more details plus I recall this being brought up on previous pull requests I've made where I missed this.

@danbev
Copy link
Contributor Author

danbev commented Nov 27, 2017

Landed in 4ca4db0

@danbev danbev closed this Nov 27, 2017
@danbev danbev deleted the base64-include-stdint branch November 27, 2017 06:25
danbev added a commit that referenced this pull request Nov 27, 2017
@danbev
src: make base64.h self-contained
4ca4db0 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
src: make base64.h self-contained
0c45b6c 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
src: make base64.h self-contained
376157d 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
src: make base64.h self-contained
63f6947 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@danbev @gibfahn
src: make base64.h self-contained
0d5075f 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@danbev @gibfahn
src: make base64.h self-contained
6792998 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@danbev @gibfahn
src: make base64.h self-contained
c602c4c 
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: #17177
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@aqrln aqrln aqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev @gireeshpunathil @jasnell @addaleax @TimothyGu @cjihrig @aqrln @gibfahn @nodejs-github-bot