doc: delete unused definition in README.md#17108
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-del-unused-definition
Closed
doc: delete unused definition in README.md#17108vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-del-unused-definition
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-del-unused-definition
Conversation
vsemozhetbyt
added
fast-track
4 tasks
Contributor
Author
addaleax
approved these changes
Nov 17, 2017
Contributor
Author
|
Do we have to wait for the complete CI or do |
Contributor
|
IMHO linter is enough, as this obviously does not touch code. |
Contributor
Author
|
Landed in ca3f9b7 |
vsemozhetbyt
added a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #17108 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
3 tasks
Member
|
🎉 Thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17108 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17108 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17108 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17108 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, meta
Please, fast track, as it fails linter CI