else:no need to use else

[Johnsavadkuhi]

good :

 if (engine._info)
    return { buffer, engine };
else
   return buffer;

better :

 if (engine._info)
    return { buffer, engine };
 return buffer;

[gibfahn]

-0 on this, I find the explicit else more readable, especially as the if doesn't have braces.

@Johnsavadkuhi why do you think it's better?

[Trott]

If we decide the style proposed here is better, we can use an ESLint's no-else-return rule to enforce it. No opinion either way from me on this.

[Johnsavadkuhi]

first , thank you a lot because of creating Nodejs for us.
more readability is good i'm java programmer and am not professional as you in JavaScript i would like to say i came here to improve my JS Skill but when i saw a lot of nested if and else and also this way to return something and i thought it's like as java or c or c++ and then i changed it.

in my opinion creating professional code helps to other programmers to improve their programming skills also i think every programmer clearly know that return statement destroy function life and without else , readability still is good

every programmer know the result is not "hello"

function x ( ){ 
if (true ) 
    return  ; 
console.log("hello") ;
} 

and then :

function y ( ) {
if (true ) 
    return ; 
else  
      console.log("hello") ; 
}

which is better ? it is simple code and both are good and the second is more readable for beginner programmer not for professional and we know a beginner have to learn more and practice more and more

let me to show you a code in zlib.js

function createConvenienceMethod(ctor, sync) {
  if (sync) {
    return function(buffer, opts) {
      return zlibBufferSync(new ctor(opts), buffer);
    };
  } else {
    return function(buffer, opts, callback) {
      if (typeof opts === 'function') {
        callback = opts;
        opts = {};
      }
      return zlibBuffer(new ctor(opts), buffer, callback);
    };
  }
}

without else :

function createConvenienceMethod(ctor, sync) {
  if (sync) {
    return function(buffer, opts) {
      return zlibBufferSync(new ctor(opts), buffer);
    };
  }
  return function(buffer, opts, callback) {
    if (typeof opts === 'function') {
      callback = opts;
      opts = {};
    }
    return zlibBuffer(new ctor(opts), buffer, callback);
  };
}

which is better and shorter ? i think the second is better because is shorter and less Braces

[Johnsavadkuhi]

...

[Trott]

No one has voiced a strong objection. (@gibfahn was a -0 which I take to mean they don't like it but wouldn't block it. Others have approved it.) So this can get a CI run and land if someone is sufficiently supportive to do that. Until that happens, it's still possible for another Collaborator to block it with an objection.

I'm neutral on this myself. I don't care one way or the other, but I do prefer consistency across the code base. So whatever is decided, I hope we can enforce with a lint rule. I suppose that would slightly favor this change, since the lint rule enforcing this style exists and could be deployed.

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/11549/

[apapirovski]

I would like to see this land because it's an eslint rule I want to enable but currently there are way too many instances that need to be fixed. If we can make a dent via this and potentially code-and-learn type of tasks, then that would make it a bit more bearable.

[jasnell]

Landed in b98027e