Get all headers 3992

[iankronquist]

Thanks @chrisdickinson for the pointer to this bug.

[iankronquist]

Github doesn't automatically link to issues in the node.js repo. Here's a link to the issue in question:
nodejs/node-v0.x-archive#3992

[chrisdickinson]

I think there might be two too many newlines here.

[iankronquist]

@chrisdickinson Fixed documentation formatting

[chrisdickinson]

It would be nice to return a copy of headers instead of the full object -- something like util.extend({}, this._headers).

[iankronquist]

@chrisdickinson Fixed according to your advice.

[phpnode]

Should probably be something like:

Returns the headers which have already been queued but not yet sent to the client.

[iankronquist]

I made changes according to @phpnode's and @bnoordhuis' comments. I then rebased to keep up with v0.12. r?

[chrisdickinson]

Apologies for dragging my feet on this a bit: this LGTM. If there are no objections I'll merge tomorrow afternoon (by 5PM PST).

[iankronquist]

@chrisdickinson No worries, I'm glad I could pitch in.

[iankronquist]

@chrisdickinson Can this be merged?

[iankronquist]

ping @chrisdickinson

[chrisdickinson]

Sorry for the late comment, but wouldn't this omit the added-by-default headers Date and Connection?

[iankronquist]

@chrisdickinson updated according to your comments.

[iankronquist]

ping @chrisdickinson

[chrisdickinson]

var headers;
var rando = Math.random();
var expected = util._extend({}, {
  'X-Random-Thing': rando,
  /* other values */
});
var server = http.createServer(function(req, res) {
  res.setHeader('X-Random-Thing', rando); 
  headers = res.getAllHeaders();
  res.end('hello');
  assert.strictEqual(res.getAllHeaders(), null);
});
server.listen(common.PORT, function() {
  http.get({port: common.PORT}, function(resp) {
    assert.deepEqual(response.headers, expected);
    server.close();
  });
});

[rvagg]

@chrisdickinson do you require further action on this? Is your last comment a request for a test case along the lines of your code block? @iankronquist if this was to be merged it'd probably need to be a single commit so you might want to squash. The license block should also be removed from the test file and it now needs to go in to test/parallel/.

[chrisdickinson]

Yes, that last comment is the test case that should be added and made to pass for this to be able to go in. Re: commits: I don't mind squashing those myself on merge.

[iankronquist]

@rvagg I'll go ahead and do that.

[iankronquist]

... and squashed like a bug. Let me know if you need anything else cleaned up.