test: test-inspector-async-hook-setup-at-signal flag as flaky#16941
test: test-inspector-async-hook-setup-at-signal flag as flaky#16941refack wants to merge 1 commit intonodejs:masterfrom
test-inspector-async-hook-setup-at-signal flag as flaky#16941Conversation
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
refack
added
flaky-test
|
Request to fast track. CI gives false negatives, and we are tracking the underlying issue in https://github.com/nodejs/node/projects/8 |
refack
changed the title
test-inspector-async-hook-setup-at-signal flag as flaky
|
Fast-tracking based on @refack 's request. We have seen this test causing random CI failures so makes sense to isolate before diagnosing |
|
Landed in 074a5c7 , don't know why the commit is not appearing here! |
|
ah, ok - the commit meta is missing! any clues what is the best way to fix it now? |
|
you can add the metadata as a comment at 074a5c7. It's too late to force-push. |
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
|
thanks @targos , done. |
|
@refack you landed this on 8.x-staging. Current process only allows for the backporting team to land on LTS branches edit: my apologies, looking at commit data it was not landed by you... sorry about that whoever landed it, please avoid landing things on 8.x-staging or 6.x-staging |
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig [email protected] Reviewed-By: Gireesh Punathil [email protected]
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig [email protected] Reviewed-By: Gireesh Punathil [email protected]
6 participants
test-inspector-async-hook-setup-at-signalis also flaky on VS2017Refs: #16771
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,inspector,windows