lib: Replacing the string concatenation with string template#16933
Closed
narkedi wants to merge 3 commits intonodejs:masterfrom
Closed
lib: Replacing the string concatenation with string template#16933narkedi wants to merge 3 commits intonodejs:masterfrom
narkedi wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
fs
gireeshpunathil
added
the
code-and-learn
Contributor
Author
|
Pushed a new commit to address the 80 character limit. |
apapirovski
approved these changes
Nov 10, 2017
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
Thanks for working on this @narkedi! Just a small change request below.
lib/fs.js
Outdated
| backtrace.stack = err.name + ': ' + err.message + | ||
| backtrace.stack.substr(backtrace.name.length); | ||
| backtrace.stack = `${err.name}: ${err.message}` + | ||
| `${backtrace.stack.substr(`${backtrace.name.length}`)}`; |
Contributor
There was a problem hiding this comment.
It looks like this second line could be left as it was. Just the first line needs to be a template literal.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review comments @apapirovski . Have made the necessary changes and did a fresh commit.
cjihrig
approved these changes
Nov 10, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with nit addressed.
jasnell
approved these changes
Nov 10, 2017
fhinkel
approved these changes
Nov 11, 2017
Member
gireeshpunathil
approved these changes
Nov 13, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16933 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in 107e8a9 , thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16933 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16933 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib