lib: Replace String concatenation with template#16922
Closed
saiHemak wants to merge 1 commit intonodejs:masterfrom
Closed
lib: Replace String concatenation with template#16922saiHemak wants to merge 1 commit intonodejs:masterfrom
saiHemak wants to merge 1 commit intonodejs:masterfrom
Conversation
gireeshpunathil
added
the
code-and-learn
lib/internal/v8_prof_polyfill.js
Outdated
Contributor
There was a problem hiding this comment.
change s as ${s} as we need to append the const variable s instead of the letter s.
saiHemak
force-pushed
the
templatefix
branch
from
1bd5aa8 to
cb2cc74
Compare
jasnell
reviewed
Nov 10, 2017
lib/internal/v8_prof_polyfill.js
Outdated
Member
There was a problem hiding this comment.
this can cover the entire line... e.g.
line = `${s} \n${line}`;
saiHemak
force-pushed
the
templatefix
branch
from
cb2cc74 to
e4e66f3
Compare
Contributor
Author
|
@jasnell Thanks for your review.I have addressed your comments |
jasnell
approved these changes
Nov 10, 2017
tniessen
approved these changes
Nov 10, 2017
cjihrig
approved these changes
Nov 10, 2017
gireeshpunathil
approved these changes
Nov 11, 2017
fhinkel
approved these changes
Nov 11, 2017
Member
Member
fhinkel
pushed a commit
that referenced
this pull request
Nov 11, 2017
PR-URL: #16922 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16922 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)