lib: replace string concatenation with template#16920
Closed
chandrams wants to merge 1 commit intonodejs:masterfrom
Closed
lib: replace string concatenation with template#16920chandrams wants to merge 1 commit intonodejs:masterfrom
chandrams wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
child_process
gireeshpunathil
added
the
code-and-learn
jasnell
reviewed
Nov 10, 2017
| return [option, option, option, 'ipc']; | ||
| default: | ||
| throw new TypeError('Incorrect value of stdio option: ' + option); | ||
| throw new TypeError(`Incorrect value of stdio option: ${option}`); |
Member
There was a problem hiding this comment.
There is another PR open that will be landing soon that changes this error message. It's likely safe to omit this change here and just wait for the other PR to land.
jasnell
reviewed
Nov 10, 2017
|
|
||
| if (!ex) { | ||
| ex = new Error('Command failed: ' + cmd + '\n' + stderr); | ||
| ex = new Error(`Command failed: ${cmd}\n${stderr}`); |
Member
There was a problem hiding this comment.
Likewise here, it's not likely worth changing the string concatenations in error throws since those will be changing very soon.
cjihrig
approved these changes
Nov 10, 2017
jasnell
approved these changes
Nov 10, 2017
Member
|
@chandrams Thanks so much for your first commit 🎉. Landed as 79f805c |
fhinkel
pushed a commit
to fhinkel/node
that referenced
this pull request
Nov 11, 2017
PR-URL: nodejs#16920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Contributor
|
This does not land cleanly in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
This is my first contribution to node. Thank you.