tools,build: allow build without remark-cli#16893
Merged
refack merged 1 commit intonodejs:masterfrom Nov 10, 2017
Merged
Conversation
a2dc284 to
5600fb7
Compare
Contributor
Author
5600fb7 to
f889a14
Compare
joyeecheung
approved these changes
Nov 10, 2017
PR-URL: nodejs#16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
f889a14 to
e624503
Compare
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Contributor
|
This should be included in a general backport of remark for v6.x |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #16635 (comment)
The
linttarget in theMakefileis dependant onremark-clibeing installed in/tools/or alternatively on internet access to thenpmregistry. The source tarball does not includeremark-clinorESLint, so this PR uses the same conditional pattern as forlint-js:node/Makefile
Lines 1082 to 1107 in d597317
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build,tools