Closed
Conversation
gireeshpunathil
added
the
code-and-learn
Contributor
|
Beware: Commit author is not associated with the GitHub account. @adamjeffery-dev Can you add the local email to your GitHub account email list? See the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
Member
|
Hi @adamjeffery-dev! Welcome and thanks for the PR! It would appear that this change has some lint errors in it. Can you please run |
Member
|
I went ahead and fixed the lint issues myself. Hope that's OK! |
Member
Trott
approved these changes
Nov 8, 2017
Author
|
Hey Rich
No problem. Sorry I'm still at NodeConf so not had chance to look at it
again.
Thanks
…On 8 Nov 2017 11:59 a.m., "Rich Trott" ***@***.***> wrote:
I went ahead and fixed the lint issues myself. Hope that's OK!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16831 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AWWq6VGy5NiMcpucGHsDjKXozFLTVHR9ks5s0ZeMgaJpZM4QTf1S>
.
|
gireeshpunathil
approved these changes
Nov 8, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: nodejs#16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in 15fa9fc. |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: #16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: #16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: #16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: #16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: #16831 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)