doc: add isTTY property documentation#16828
Closed
sonaysevik wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
doc
gireeshpunathil
approved these changes
Nov 6, 2017
gireeshpunathil
added
the
code-and-learn
cjihrig
approved these changes
Nov 6, 2017
sam-github
approved these changes
Nov 6, 2017
Contributor
|
@sonaysevik FYI, PRs have to sit for 2 work days to give folks a chance to review, then they can be landed. |
Member
Member
|
@sam-github I think we have relaxed the rule a bit recently. In the collaborator guide it's now documented as:
|
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
PR-URL: nodejs#16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Member
|
Landed in 37c1188. |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
PR-URL: nodejs#16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2018
PR-URL: #16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
PR-URL: #16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
PR-URL: #16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
PR-URL: #16828 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
@sam-github