build: add missing options to help message#16707
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
build: add missing options to help message#16707danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit add missing options to the Windows help message and removes options that no longer exist (test-uv).
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Nov 3, 2017
gireeshpunathil
approved these changes
Nov 3, 2017
cjihrig
approved these changes
Nov 3, 2017
jasnell
approved these changes
Nov 3, 2017
danbev
added a commit
that referenced
this pull request
Nov 8, 2017
This commit add missing options to the Windows help message and removes options that no longer exist (test-uv). PR-URL: #16707 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Landed in 71e7366 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
This commit add missing options to the Windows help message and removes options that no longer exist (test-uv). PR-URL: #16707 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Contributor
|
Should this be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, windows