inspector: include node_platform.h header#16677
inspector: include node_platform.h header#16677alexeykuzmin wants to merge 1 commit intonodejs:masterfrom
Conversation
Include the header instead of using a forward declaration.
|
@gireeshpunathil Is it normal that CI jobs are in the pending state for almost 3 days already? |
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
@alexeykuzmin - actually the CI has been completed in time, but the view in github is not updated to reflect that fact - probably a bug - @nodejs/collaborators - please share any prior art on this if you know. Landed in 916e1cb , thanks for the contribution! |
Yeah, bug in the bot used to update that stuff. I think @maclover7 recently fixed it or was working on fixing it. |
|
@gireeshpunathil @Trott Build statuses should be reporting properly for all |
Include the header instead of using a forward declaration. PR-URL: nodejs#16677 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
When Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them.
It would be great if the code could be changed in the Node.js repo so Electron wouldn't have to have a patch for that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector