build: use bin path override if no python is found in PATH by bradleythughes · Pull Request #16241 · nodejs/node

bradleythughes · 2017-10-16T20:41:14Z

On systems with no "python" in the PATH, e.g. when building with poudriere on FreeBSD, we should always create a python symlink in get_bin_override(). Otherwise, configure fails with the following error:

Traceback (most recent call last):
  File "./configure", line 1461, in <module>
    bin_override = get_bin_override()
  File "./configure", line 1360, in get_bin_override
    if os.path.realpath(which('python')) == os.path.realpath(sys.executable):
  File "/usr/local/lib/python2.7/posixpath.py", line 375, in realpath
    path, ok = _joinrealpath('', filename, {})
  File "/usr/local/lib/python2.7/posixpath.py", line 381, in _joinrealpath
    if isabs(rest):
  File "/usr/local/lib/python2.7/posixpath.py", line 54, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

bradleythughes · 2017-10-16T20:44:31Z

This happens with the recently released v8.7.0 as well, so if it's possible to land this on v8.x, I'd be very appreciative. :)

gibfahn · 2017-10-16T21:06:00Z

Wow, never occurred to me that there were systems/configurations without a python defined.

cc/ @forivall @addaleax @bengl @bnoordhuis @nodejs/python , PTAL

gireeshpunathil · 2017-10-17T05:09:58Z

I am sorry, but not sure I understand - On systems with no "python" in the PATH , the stack trace that you listed is not possible right? as that trace itself is a python manifestation?

forivall · 2017-10-17T05:22:12Z

I'm guessing that it means systems where there's a python2 and maybe python3 but no python, or that python is just installed somewhere not on the path.

bradleythughes · 2017-10-17T05:34:29Z

That's correct. There is python2.7 and python2 in the path, but no python.

gireeshpunathil · 2017-10-17T05:56:53Z

thanks @forivall and @bradleythughes. Can you also please have a look at #16058 and #14737 and see that this is supplementing / complimenting to those? I am also trying to relate these.

bradleythughes · 2017-10-17T06:26:25Z

@gireeshpunathil Yes, I found both of those PRs when I hit the configure error shown above with the v8.7.0 release. This PR addresses a specific situation not covered by the other two, so yes, I would say this PR is both complimentary and supplementary. 🙂

bnoordhuis

LGTM modulo style nit.

configure

thefourtheye

LGTM with @bnoordhuis's comment.

On systems with no "python" in the PATH, e.g. FreeBSD, we should always create a python symlink in get_bin_override(). Otherwise, configure fails with the following error: Traceback (most recent call last): File "./configure", line 1461, in <module> bin_override = get_bin_override() File "./configure", line 1360, in get_bin_override if os.path.realpath(which('python')) == os.path.realpath(sys.executable): File "/usr/local/lib/python2.7/posixpath.py", line 375, in realpath path, ok = _joinrealpath('', filename, {}) File "/usr/local/lib/python2.7/posixpath.py", line 381, in _joinrealpath if isabs(rest): File "/usr/local/lib/python2.7/posixpath.py", line 54, in isabs return s.startswith('/') AttributeError: 'NoneType' object has no attribute 'startswith'

gireeshpunathil · 2017-10-18T05:51:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10805/

gireeshpunathil · 2017-10-22T05:44:09Z

More CI failures than I can comprehend, running it once again:
CI: https://ci.nodejs.org/job/node-test-pull-request/10897/

refack · 2017-10-22T18:47:55Z

Landed in 02a5267

Thanks!

On systems with no "python" in the PATH, e.g. FreeBSD, we should always create a python symlink in get_bin_override(). PR-URL: #16241 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

On systems with no "python" in the PATH, e.g. FreeBSD, we should always create a python symlink in get_bin_override(). PR-URL: nodejs/node#16241 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins · 2017-11-14T20:36:00Z

can we get a backport to v6.x?

refack · 2017-11-14T20:37:03Z

Backporting now.

MylesBorins · 2017-11-14T20:37:37Z

@refack NVM... lands cleanly with #16058

On systems with no "python" in the PATH, e.g. FreeBSD, we should always create a python symlink in get_bin_override(). PR-URL: #16241 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

On systems with no "python" in the PATH, e.g. FreeBSD, we should always create a python symlink in get_bin_override(). PR-URL: nodejs/node#16241 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 16, 2017

gibfahn approved these changes Oct 16, 2017

View reviewed changes

gibfahn mentioned this pull request Oct 16, 2017

build: allow build with system python 3 #16058

Closed

2 tasks

gireeshpunathil approved these changes Oct 17, 2017

View reviewed changes

bnoordhuis approved these changes Oct 17, 2017

View reviewed changes

configure Outdated Show resolved Hide resolved

thefourtheye approved these changes Oct 17, 2017

View reviewed changes

bradleythughes force-pushed the build-use-bin-override-if-no-python branch from b165063 to 0f1872c Compare October 17, 2017 19:47

refack approved these changes Oct 22, 2017

View reviewed changes

refack closed this Oct 22, 2017

MylesBorins added the backport-requested-v6.x label Nov 14, 2017

refack self-assigned this Nov 14, 2017

MylesBorins added land-on-v6.x and removed backport-requested-v6.x labels Nov 14, 2017

refack removed their assignment Nov 14, 2017

MylesBorins mentioned this pull request Nov 21, 2017

v6.12.1 proposal #17180

Merged

bradleythughes deleted the build-use-bin-override-if-no-python branch September 30, 2020 21:13

Uh oh!

Conversation

bradleythughes commented Oct 16, 2017

Checklist

Affected core subsystem(s)

Uh oh!

bradleythughes commented Oct 16, 2017

Uh oh!

gibfahn commented Oct 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gireeshpunathil commented Oct 17, 2017

Uh oh!

forivall commented Oct 17, 2017

Uh oh!

bradleythughes commented Oct 17, 2017

Uh oh!

gireeshpunathil commented Oct 17, 2017

Uh oh!

bradleythughes commented Oct 17, 2017

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thefourtheye left a comment

Choose a reason for hiding this comment

Uh oh!

gireeshpunathil commented Oct 18, 2017

Uh oh!

gireeshpunathil commented Oct 22, 2017

Uh oh!

refack commented Oct 22, 2017

Uh oh!

MylesBorins commented Nov 14, 2017

Uh oh!

refack commented Nov 14, 2017

Uh oh!

MylesBorins commented Nov 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gibfahn commented Oct 16, 2017 •

edited

Loading