test: increase fs.exists coverage#15963
Closed
NigelKibodeaux wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Trott
added
the
code-and-learn
cjihrig
reviewed
Oct 7, 2017
test/parallel/test-fs-exists.js
Outdated
Contributor
There was a problem hiding this comment.
This should probably assert something.
Member
There was a problem hiding this comment.
For instance,
assert.doesNotThrow(() => fs.exists(f));
Contributor
Author
There was a problem hiding this comment.
Thanks, I just fixed it.
cjihrig
reviewed
Oct 10, 2017
test/parallel/test-fs-exists.js
Outdated
Contributor
There was a problem hiding this comment.
This isn't quite right yet. In this case, fs.exists(f) will be evaluated, and the return value will be passed to assert.doesNotThrow(). If you wrap fs.exists(f) in a function first, then it will be good to go. It would look like:
assert.doesNotThrow(() => { fs.exists(f); });
Member
|
Ping @NigelKibodeaux |
apapirovski
approved these changes
Oct 18, 2017
gireeshpunathil
approved these changes
Oct 19, 2017
Member
cjihrig
approved these changes
Oct 19, 2017
BridgeAR
approved these changes
Oct 19, 2017
Member
|
CI failed with merge conflict. My guess it because of the different commeints. @NigelKibodeaux could you squash the commits down to 1 ? |
Contributor
|
Hi @NigelKibodeaux, would you still like to follow up on this so that it can land in Node? Let me know if I can offer any pointers. Thanks for helping improve Node! |
NigelKibodeaux
force-pushed
the
fs-exists-coverage
branch
from
70c18e1 to
e714c42
Compare
Contributor
Author
|
Hi @apapirovski, I'm attempting to squash my commits. I hope this works... |
Contributor
|
@NigelKibodeaux seems to have worked 😄 I'll get a CI started and post a link shortly. Edit: oops, can you remove the merge commit. Let me know if you need pointers. |
tniessen
force-pushed
the
fs-exists-coverage
branch
from
3c5d976 to
7bcf844
Compare
Member
|
I rebased and pushed for you 😃 CI: https://ci.nodejs.org/job/node-test-commit/13558/ (For further reference, NigelKibodeaux@6d9abdd is the original commit.) |
tniessen
pushed a commit
that referenced
this pull request
Oct 28, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed in 4ed152e, thank you! 🎉 |
Contributor
Author
|
Thanks!
…On Sat, Oct 28, 2017 at 1:51 PM Tobias Nießen ***@***.***> wrote:
Closed #15963 <#15963>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15963 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAY8dJlpNJxzY2xXq_PdfDPF2zK1ZC3Oks5sw6HfgaJpZM4Pw0Z1>
.
|
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15963 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests the case of calling
fs.existswithout a callback.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test