Url accessor fixes

[petkaantonov]

See #1588

Also includes a commit that fixes href cache invalidation bug as described in #1588 (comment)

cc: @silverwind @domenic @rvagg @chrisdickinson

[petkaantonov]

Can someone test with restify? All tests pass now with request. I cannot get restify to work at all

[silverwind]

I'll compile and test both again.

[bnoordhuis]

Uninformed LGTM with a question.

[silverwind]

request and restify install fine, except I get the usual gyp 404 with nightly builds, which is unrelated.

[silverwind]

The href cache updating looks fixed too.

[Fishrock123]

With this patch applied make test-npm still appears to fail? https://gist.github.com/Fishrock123/bfbc8e873c53a144e169

[petkaantonov]

make test-npm seems to use installed io.js, not the one you just built. From your output it really appears that you are just testing with the 2.0RC, not with this patch as it should not be even possible to have an url with empty hash now.

[silverwind]

Unrelated to this PR, but notices this npm test failure:

Command: "/usr/local/bin/iojs config-credentials.js"

        found:  |
          https://registry.lvh.me:8661/
        wanted: |
          //registry.lvh.me:8661/

test: https://github.com/npm/npm/blob/master/test/tap/config-credentials.js
uses: https://github.com/npm/npm/blob/master/lib/config/clear-credentials-by-uri.js
which uses: https://github.com/npm/npm/blob/master/lib/config/nerf-dart.js

The final file is of interest, it deletes a lot of url properties.

[silverwind]

opened #1591 for the delete issue.

[silverwind]

Also, LGTM on this patch.

[petkaantonov]

Landed in 6687721