[v6.x backport] assert: refactor the code#15516
Closed
BridgeAR wants to merge 2 commits intonodejs:v6.x-stagingfrom
Closed
[v6.x backport] assert: refactor the code#15516BridgeAR wants to merge 2 commits intonodejs:v6.x-stagingfrom
BridgeAR wants to merge 2 commits intonodejs:v6.x-stagingfrom
Conversation
c0f68fe to
f61906a
Compare
Member
Author
|
@MylesBorins we have a linter error on v6.x-staging diff --git a/test/parallel/test-fs-readfile-unlink.js b/test/parallel/test-fs-readfile-unlink.js
index aa17324963..203ea681e5 100644
--- a/test/parallel/test-fs-readfile-unlink.js
+++ b/test/parallel/test-fs-readfile-unlink.js
@@ -3,7 +3,6 @@ const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
-const dirName = path.resolve(common.fixturesDir, 'test-readfile-unlink');
const fileName = path.resolve(common.tmpDir, 'test.bin');
const buf = Buffer.alloc(512 * 1024, 42);I am not sure how we should fix that. Should I just open a new PR against the branch? |
a056404 to
9b770b3
Compare
Contributor
|
@BridgeAR I fixed this in the staging branch. give it another rebase 😄 |
1. Rename private functions 2. Use destructuring 3. Remove obsolete comments PR-URL: nodejs#13862 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#13862 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
f61906a to
f428371
Compare
Member
Author
|
@MylesBorins rebased |
Contributor
|
landed in 55a2bd2...a8b34d8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #13862
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
assert