test: fix single test runner regression#15300
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix single test runner regression#15300apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
Fixes regression in ability to run single tests. Refs: nodejs@c8a389e
mscdex
added
the
python
Trott
approved these changes
Sep 11, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green. Thanks for catching/fixing this.
Member
|
If we can get some more reviews on this, I'd be +1 on landing it sooner than the usual 48/72 hours. |
Member
This was referenced Sep 11, 2017
Member
|
Another reason to expedite this: I don't think the CI single-stress-test job will work again until this lands. @nodejs/testing |
3 tasks
Member
|
I have an alternative version that's a bit cleaner IMO: #15329 My bad for break it :( |
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Sep 11, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
When ESM support was added it created a regression in the test runner that broke the ability to run individual tests. This commit re-introduces the use of `NormalizePath` which fixes the regression in the test runner Refs: #15300 PR-URL: #15329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
When ESM support was added it created a regression in the test runner that broke the ability to run individual tests. This commit re-introduces the use of `NormalizePath` which fixes the regression in the test runner Refs: #15300 PR-URL: #15329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
When ESM support was added it created a regression in the test runner that broke the ability to run individual tests. This commit re-introduces the use of `NormalizePath` which fixes the regression in the test runner Refs: nodejs#15300 PR-URL: nodejs#15329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent commit c8a389e broke the ability to run single tests without adding * to the end of the name. This fixes it.
You can test by running
python tools/test.py -J --mode=release es-module/test-esm-pkg-over-extbefore and after this patch.If there's a cleaner way to accomplish the same, please let me know. Thanks!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test