process: improve process warning coverage#15212
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
process: improve process warning coverage#15212jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
refack
approved these changes
Sep 6, 2017
Member
|
Nit: subsystem should probably be |
jasnell
force-pushed
the
process-warning-coverage
branch
from
1852fbc to
21e26b3
Compare
danbev
approved these changes
Sep 6, 2017
cjihrig
approved these changes
Sep 6, 2017
benjamingr
approved these changes
Sep 6, 2017
lpinca
approved these changes
Sep 6, 2017
Member
tniessen
approved these changes
Sep 11, 2017
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
I would consider renaming the file to test-process-warning, we are not testing the coverage here.
jasnell
added a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #15212 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
Author
|
Landed in 8c2eba0 |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
PR-URL: nodejs#15212 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell
added a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #15212 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
process