timers: modified comment to try/finally#15205
Closed
Moniarchy wants to merge 1 commit intonodejs:masterfrom
Closed
timers: modified comment to try/finally#15205Moniarchy wants to merge 1 commit intonodejs:masterfrom
Moniarchy wants to merge 1 commit intonodejs:masterfrom
Conversation
Replaced try/catch with try/finally in comments, line 744. Fixes: nodejs#14308
Member
|
Not even sure if the comment applies any more since try blocks should be optimized now. But, in general, LGTM |
Member
|
There is actually already a open PR for this: #14314 |
Contributor
|
Hello @Moniarchy and welcome. Thank for the contribution 🥇 Lines 775 to 794 in b8c142c |
Member
|
This got superseded by a2b6872 @Moniarchy thanks for your contribution anyway! Looking forward to your next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced try/catch with try/finally in comments, line 744.
Fixes: #14308
Checklist
Affected core subsystem(s)