deps: cherry-pick 1aead19 from upstream V8#15184
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
deps: cherry-pick 1aead19 from upstream V8#15184bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
Refs: nodejs/llnode#117
Refs: nodejs/llnode#121
nodejs-github-bot
added
post-mortem
cjihrig
approved these changes
Sep 4, 2017
targos
approved these changes
Sep 4, 2017
joyeecheung
approved these changes
Sep 5, 2017
BridgeAR
approved these changes
Sep 5, 2017
jasnell
approved these changes
Sep 5, 2017
Member
jasnell
pushed a commit
that referenced
this pull request
Sep 7, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in ca78180 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Sep 12, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
PR-URL: nodejs#15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 13, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
PR-URL: nodejs#15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
PR-URL: nodejs#15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Sep 14, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
PR-URL: nodejs#15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Contributor
|
@bnoordhuis I've backported to v6.x |
Contributor
|
nvm it didn't land cleanly. lmk if we should backport |
targos
pushed a commit
to targos/node
that referenced
this pull request
Sep 21, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#47778}
PR-URL: nodejs#15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Member
Author
|
Doesn't need to be back-ported. I've added labels. |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
Backport-PR-URL: #15393
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
Backport-PR-URL: #15393
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Ben Noordhuis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47778}
Backport-PR-URL: #15393
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: nodejs/llnode#117
Refs: nodejs/llnode#121
cc @joyeecheung