Fix broken openssl links#15182
Closed
kasicka wants to merge 2 commits intonodejs:v4.x-stagingfrom
kasicka:fix-spkac-link
Closed
Fix broken openssl links#15182kasicka wants to merge 2 commits intonodejs:v4.x-stagingfrom kasicka:fix-spkac-link
kasicka wants to merge 2 commits intonodejs:v4.x-stagingfrom
kasicka:fix-spkac-link
Conversation
nodejs-github-bot
added
crypto
targos
approved these changes
Sep 4, 2017
Member
|
There are probably other dead links. It was fixed in #9338 which was not backported to v4.x. |
cjihrig
approved these changes
Sep 4, 2017
Author
|
Fixed other links I found. |
lpinca
approved these changes
Sep 5, 2017
silverwind
approved these changes
Sep 8, 2017
Contributor
silverwind
left a comment
silverwind
left a comment
There was a problem hiding this comment.
Not a fan of versions in links, but I guess we can't really do anything about it.
danbev
approved these changes
Sep 8, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
PR-URL: #15182 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Contributor
|
landed in fc6145f |
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
PR-URL: #15182 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found dead link in doc, seems fixed in later releases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc