test: add test-benchmark-assert by Trott · Pull Request #15174 · nodejs/node

Trott · 2017-09-04T05:28:37Z

First commit:

benchmark: enable assert benchmark with short len

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to
a hardcoded index. Calculate the index based on `len` so benchmark can
be run with small `len` values if desired.

Second commit:

benchmark: provide default methods for assert

The benchmarks for `assert` all take a `method` configuration option,
but the allowable values are different across the files. For each
benchmark, provide an arbitrary default if `method` is set to an empty
string. This allows all the `assert` benchmarks to be run with a single
command but only on a single method. This is primarily useful for
testing that the assert benchmark files don't contain egregious errors.
(In other words, it's useful for testing.)

Third commit:

test: add test-benchmark-assert

Add minimal test for `assert` benchmarks.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test benchmark assert

targos · 2017-09-04T07:41:25Z

benchmark/assert/deepequal-typedarrays.js

did you intend to use len?

did you intend to use len?

@targos Yes, oops!

BridgeAR

LGTM % comments.

BridgeAR · 2017-09-07T22:40:52Z

benchmark/assert/deepequal-buffer.js

Would you be so kind and a a comment why this is necessary? Otherwise I would be confused by this.

Done here and in the other 8 places it occurs in other files.

BridgeAR · 2017-09-13T18:24:10Z

Ping @Trott

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired.

The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.)

Add minimal test for `assert` benchmarks.

Trott · 2017-09-13T19:49:48Z

I've refactored the test to use the common/benchmark.js module that was added by @maclover7 recently.

Trott · 2017-09-13T19:50:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10063/

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired. PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add minimal test for `assert` benchmarks. PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2017-09-15T22:40:13Z

Landed in 11f46a2, 3c4c0db, and a901849

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired. PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add minimal test for `assert` benchmarks. PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2017-09-20T16:20:34Z

This lands cleanly in v8.x-staging but the test fails because ../common/benchmark does not exist. It needs a backport PR. Ping @Trott

The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired. PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add minimal test for `assert` benchmarks. PR-URL: #15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired. PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add minimal test for `assert` benchmarks. PR-URL: nodejs/node#15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2017-09-25T04:27:03Z

@jasnell It looks like you subsequently landed these, obviating the need for a backport. I'm going to remove the backport-requested label. Let me know if that's wrong and/or you need anything more from me on this.

MylesBorins · 2017-10-17T04:20:29Z

lts?

Trott · 2017-10-18T02:47:33Z

lts?

If it lands cleanly, yes. If it doesn't, probably not worth it.

MylesBorins · 2017-10-19T19:25:49Z

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Trott · 2017-10-21T23:25:19Z

@MylesBorins Is this supposed to be labeled do-not-land-on-v6.x rather than land-on-v6.x?

MylesBorins · 2017-10-23T19:49:59Z

@Trott indeed

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Sep 4, 2017

targos reviewed Sep 4, 2017

View reviewed changes

BridgeAR approved these changes Sep 7, 2017

View reviewed changes

benchmark: enable assert benchmark with short len

5a2ce48

`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired.

Trott force-pushed the vacay-9 branch from ae11058 to 09e30f4 Compare September 13, 2017 19:31

Trott force-pushed the vacay-9 branch from 09e30f4 to f4eac79 Compare September 13, 2017 19:41

BridgeAR approved these changes Sep 13, 2017

View reviewed changes

test: add test-benchmark-assert

2405a3f

Add minimal test for `assert` benchmarks.

Trott force-pushed the vacay-9 branch from f4eac79 to 2405a3f Compare September 13, 2017 19:48

targos approved these changes Sep 13, 2017

View reviewed changes

jasnell approved these changes Sep 13, 2017

View reviewed changes

jasnell closed this Sep 15, 2017

jasnell added the backport-requested-v8.x label Sep 20, 2017

jasnell mentioned this pull request Sep 20, 2017

Node.js 8.6.0 Release Proposal #15509

Merged

Trott removed the backport-requested-v8.x label Sep 25, 2017

MylesBorins added the lts-watch-v6.x label Oct 17, 2017

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Oct 19, 2017

MylesBorins added dont-land-on-v6.x and removed land-on-v6.x labels Oct 23, 2017

Trott deleted the vacay-9 branch January 13, 2022 22:46

Uh oh!

Conversation

Trott commented Sep 4, 2017

Checklist

Affected core subsystem(s)

Uh oh!

targos Sep 4, 2017

Choose a reason for hiding this comment

Uh oh!

Trott Sep 4, 2017

Choose a reason for hiding this comment

Uh oh!

BridgeAR left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BridgeAR Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

Trott Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Sep 13, 2017

Uh oh!

Trott commented Sep 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Sep 13, 2017

Uh oh!

jasnell commented Sep 15, 2017

Uh oh!

jasnell commented Sep 20, 2017

Uh oh!

Trott commented Sep 25, 2017

Uh oh!

MylesBorins commented Oct 17, 2017

Uh oh!

Trott commented Oct 18, 2017

Uh oh!

MylesBorins commented Oct 19, 2017

Uh oh!

Trott commented Oct 21, 2017

Uh oh!

MylesBorins commented Oct 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BridgeAR left a comment •

edited

Loading

Trott commented Sep 13, 2017 •

edited

Loading