test: add http2 compat setTimeout tests#15156
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
test: add http2 compat setTimeout tests#15156apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout
3 tasks
benjamingr
requested changes
Sep 3, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Hey, thanks for doing this!
Why are the tests skipped if there is no crypto?
Member
|
@benjamingr http2 requires crypto. |
benjamingr
approved these changes
Sep 3, 2017
lpinca
approved these changes
Sep 3, 2017
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
LGTM, maybe we can use a single file for both request.setTimeout() and response.setTimeout() but I'm also fine with it as is.
Member
|
@benjamingr The tests are skipped because the |
Member
jasnell
approved these changes
Sep 7, 2017
jasnell
pushed a commit
that referenced
this pull request
Sep 7, 2017
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout PR-URL: #15156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 91dc507 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout PR-URL: #15156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout PR-URL: #15156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout PR-URL: #15156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Add tests for Http2ServerRequest and Http2ServerResponse setTimeout PR-URL: nodejs#15156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for Http2ServerRequest and Http2ServerResponse
setTimeout. Let me know if I should adjust anything!Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test