doc: Use readFileSync instead of fs.readFileSync in ALPN sample#15137
Closed
miensol wants to merge 1 commit intonodejs:masterfrom
Closed
doc: Use readFileSync instead of fs.readFileSync in ALPN sample#15137miensol wants to merge 1 commit intonodejs:masterfrom
readFileSync instead of fs.readFileSync in ALPN sample#15137miensol wants to merge 1 commit intonodejs:masterfrom
Conversation
The ALPN negotiation sample uses `fs.readFileSync` whereas `readFileSync` is imported into top level variable.
nodejs-github-bot
added
doc
benjamingr
approved these changes
Sep 1, 2017
jasnell
approved these changes
Sep 1, 2017
vsemozhetbyt
approved these changes
Sep 1, 2017
targos
approved these changes
Sep 1, 2017
Member
|
(btw, I'm not sure this needs to wait the full 48/72 hours to land) |
refack
approved these changes
Sep 1, 2017
Contributor
Landing |
refack
pushed a commit
that referenced
this pull request
Sep 1, 2017
The ALPN negotiation sample uses `fs.readFileSync` whereas `readFileSync` is imported into top level variable. PR-URL: #15137 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
Contributor
|
Not sure what happened here. Is destructuring core module methods a thing? Why is it inconsistent now? Should it not have been rather fixing it at require level? |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
The ALPN negotiation sample uses `fs.readFileSync` whereas `readFileSync` is imported into top level variable. PR-URL: nodejs/node#15137 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
The ALPN negotiation sample uses `fs.readFileSync` whereas `readFileSync` is imported into top level variable. PR-URL: #15137 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
The ALPN negotiation sample uses `fs.readFileSync` whereas `readFileSync` is imported into top level variable. PR-URL: #15137 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALPN negotiation sample uses fs.readFileSync. However
readFileSyncis imported into top level variable and should thus be used instead.
Checklist
Affected core subsystem(s)
doc