doc,lib,src,test: strip executable bits off files#15132
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
doc,lib,src,test: strip executable bits off files#15132addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove the executable bits of the file modes of some files that accidentally received it.
nodejs-github-bot
added
c++
targos
approved these changes
Sep 1, 2017
cjihrig
approved these changes
Sep 1, 2017
benjamingr
approved these changes
Sep 1, 2017
Member
|
sigh. thank you. I ended up blowing away my local github set up a few weeks ago and completely forgot to set the config switch to ignore those. |
Member
|
it's switched on now! :-) (for those who don't know, this is what happens when the code is sitting in an Ubuntu VM and you're using Visual Studio Code on Windows through a mapped drive to edit. The file permissions "helpfully" get changed for you.) |
jasnell
approved these changes
Sep 1, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This doesn't need to wait the 48 hours to land
jasnell
pushed a commit
that referenced
this pull request
Sep 1, 2017
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in dd52cad |
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: nodejs/node#15132 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the executable bits of the file modes of some files that
accidentally received it.
@jasnell ;)