Closed
Conversation
4 tasks
jasnell
approved these changes
Sep 1, 2017
claudiorodriguez
approved these changes
Sep 3, 2017
Member
Author
|
Ping @addaleax |
Member
Author
|
I would like to land this relatively soon. If there are no objections in the next two days, I would just go ahead and land this. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 11, 2017
PR-URL: nodejs#15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Member
Author
|
Landed in f154c83 |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
PR-URL: nodejs#15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Member
|
@BridgeAR Can you use that explanation in the commit log next time, please? Rule of thumb: the log should explain what changed and why - not just what, that's usually easy enough to divine from the diff. |
Member
Author
|
@bnoordhuis will definitely do. I agree that this would help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #14881 the test added in da1af3d started to fail for me. So I digged into that and realized that the output is not coming from the console.log in the catch part but from "somewhere". When applying the following patch it will print something different then expected.
When adding a
console.log()orprocess.stdout.write("")before the test it will not print"e"either butSo the test is not working as anticipated and I removed it so #14881 can land.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test