doc: fix comment about http2.createSecureServer#15085
Closed
creeperyang wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix comment about http2.createSecureServer#15085creeperyang wants to merge 1 commit intonodejs:masterfrom
creeperyang wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
benjamingr
approved these changes
Aug 30, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
jasnell
approved these changes
Aug 30, 2017
Member
|
This does not need to wait the 48 hours to land |
jasnell
pushed a commit
that referenced
this pull request
Aug 30, 2017
PR-URL: #15085 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4218afc |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
PR-URL: nodejs#15085 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
PR-URL: nodejs/node#15085 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #15085 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #15085 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc