test: add a test for Expect & checkExpectation#15040
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
test: add a test for Expect & checkExpectation#15040apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
New test case for Expect header & checkExpectation event based on the existing http test case. Refs: nodejs#14985
apapirovski
force-pushed
the
patch-http2-expect-header-test
branch
from
8ffd661 to
922bbe2
Compare
jasnell
reviewed
Aug 29, 2017
| function nextTest(testsToRun) { | ||
| if (!testsToRun) { | ||
| return server.close(); | ||
| } |
Member
There was a problem hiding this comment.
This can use the new Countdown utility under common... e.g.
const Countdown = require('../common/countdown');
const countdown = new Countdown(2, () => console.log('done'));
countdown.dec();
countdown.dec();
jasnell
approved these changes
Aug 29, 2017
hiroppy
approved these changes
Aug 29, 2017
Member
hiroppy
left a comment
hiroppy
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Contributor
Author
|
So I just noticed that the documentation for the |
cjihrig
approved these changes
Aug 29, 2017
Member
Member
|
Yes, a separate PR adding the |
Member
|
Landed in 6eeb06f |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
New test case for Expect header & checkExpectation event based on the existing http test case. PR-URL: nodejs#15040 Refs: nodejs#14985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
New test case for Expect header & checkExpectation event based on the existing http test case. PR-URL: nodejs/node#15040 Refs: nodejs/node#14985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test case for Expect header & checkExpectation event, based on the existing http test case with structural tweaks to make it a bit easier to follow. Part of increasing http2 code coverage as per #14985
Let me know if I should change anything!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test