Closed
Conversation
nodejs-github-bot
added
addons
2 tasks
Test more current behaviour, based on discussions in nodejs#14697.
addaleax
force-pushed
the
test-async-makecallback
branch
from
9b48e76 to
610542e
Compare
trevnorris
approved these changes
Aug 22, 2017
Contributor
trevnorris
left a comment
trevnorris
left a comment
There was a problem hiding this comment.
two nits. otherwise LGTM
| } | ||
| } | ||
|
|
||
| template <bool use_makecallback> |
Contributor
There was a problem hiding this comment.
nit: mind adding the empty line above this again?
| v8::Local<v8::Function> callback = | ||
| v8::Local<v8::Function>::New(isolate, req->callback); | ||
| callback->Call(isolate->GetCurrentContext()->Global(), 2, argv); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: trailing whitespace here
Member
Author
There was a problem hiding this comment.
thanks for catching this!
jasnell
approved these changes
Aug 23, 2017
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/11987/ This should be ready. |
Member
Author
|
Landed in 7e54424 |
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
Test more current behaviour, based on discussions in nodejs/node#14697. PR-URL: nodejs/node#14922 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
Test more current behaviour, based on discussions in nodejs/node#14697. PR-URL: nodejs/node#14922 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test more current behaviour, based on discussions in #14697.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (presumably … do you know how longmake testtakes by now?)Affected core subsystem(s)
test/addons
@trevnorris
Quick CI: https://ci.nodejs.org/job/node-test-commit-linuxone/8090/nodes=rhel72-s390x/