benchmark: removed unused arguments from callbacks#14919
Closed
abhishek-raj wants to merge 1 commit intonodejs:masterfrom
abhishek-raj:abhishekraj-branch
Closed
benchmark: removed unused arguments from callbacks#14919abhishek-raj wants to merge 1 commit intonodejs:masterfrom abhishek-raj:abhishekraj-branch
abhishek-raj wants to merge 1 commit intonodejs:masterfrom
abhishek-raj:abhishekraj-branch
Conversation
Removed unused arguments 'buf' and 'rinfo' from the callbacks.
nodejs-github-bot
added
benchmark
Contributor
|
FWIW (in general) the reason this was done was because at least some time ago, V8 would perform optimizations when the number of parameters matched the number of arguments being passed. I do not know if this is the case any longer though. |
Contributor
|
cc @nodejs/v8 |
Member
|
Quick side-by-side runs seem to suggest that removing the unused arguments seems to not significantly affect performance of these benchmarks. But a more thorough check or informed opinion would be welcome. |
jasnell
approved these changes
Aug 18, 2017
tniessen
approved these changes
Aug 18, 2017
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Change LGTM, performance should be considered by @nodejs/v8.
lpinca
approved these changes
Aug 19, 2017
BridgeAR
approved these changes
Aug 19, 2017
Member
jasnell
pushed a commit
that referenced
this pull request
Aug 21, 2017
Removed unused arguments 'buf' and 'rinfo' from the callbacks. PR-URL: #14919 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 36817f7 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Removed unused arguments 'buf' and 'rinfo' from the callbacks. PR-URL: #14919 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Removed unused arguments 'buf' and 'rinfo' from the callbacks. PR-URL: #14919 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused arguments 'buf' and 'rinfo' from the callbacks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark