Conversation
nodejs-github-bot
added
build
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM pending reverted being a single global variable again
src/node_revert.h
Outdated
There was a problem hiding this comment.
This can’t be static, it would give every source file an independent copy.
There was a problem hiding this comment.
fwiw, node_revert.h is only imported by node.cc, but point taken :-)
There was a problem hiding this comment.
That’s partly because we’re not actually reverting anything currently. ;)
|
Quastion: what is it used for? |
|
On the hopefully quite rare occasion when a critical security fix is made, there is a non-zero possibility that it could break someone's code. The This is one of those odd bits of code that ideally would not be used but is important to have just in case. |
|
Cancelled the CI... weird failures there... trying again: https://ci.nodejs.org/job/node-test-pull-request/9717/ |
|
Ah... after rebasing there was a reverted commit that was messing things up... trying again: CI: https://ci.nodejs.org/job/node-test-pull-request/9718/ |
|
CI is good. Failures there are unrelated. |
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup PR-URL: #14864 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 35f6e59 |
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup PR-URL: #14864 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup PR-URL: #14864 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Should this be backported to |
5 participants
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src