deps: fix inspector v8 test#14827
Merged
eugeneo merged 0 commit intonodejs:masterfrom Aug 16, 2017
eugeneo:test-v8
Merged
Conversation
nodejs-github-bot
added
the
v8 engine
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/852/ Note that this test is not exercised in regular Node CI. |
addaleax
approved these changes
Aug 14, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM; can you link to the original patch that this is taken from in the commit message?
Contributor
Author
Done (in the commit, not the PR description) |
jasnell
approved these changes
Aug 16, 2017
targos
approved these changes
Aug 16, 2017
Contributor
Author
|
Landed as cd9f81d |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
This fixes the inspector tests failing after the cherry-pick. V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805 PR-URL: #14827 Fixes: #14824 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
This fixes the inspector tests failing after the cherry-pick. V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805 PR-URL: #14827 Fixes: #14824 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the inspector tests failing after the cherry-pick.
Fixes: #14824
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps: added a missing function.