test: fix test-cluster-send-handle-large-payload#14780
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix test-cluster-send-handle-large-payload#14780Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess Fixes: nodejs#14747
Trott
added
cluster
Member
Author
|
@nodejs/platform-macos @addaleax @matthewloring @bnoordhuis @cjihrig @mcollina |
Member
Author
Member
Author
|
CI is green. Stress test for current master (shows errors): https://ci.nodejs.org/job/node-stress-single-test/1372/nodes=osx1010/ Stress test for this pull request (green!): https://ci.nodejs.org/job/node-stress-single-test/1371/nodes=osx1010/ |
Member
|
LGTM but I would really kind of prefer to figure out why this is failing … |
Member
Author
Would a |
Member
|
@Trott I think either would be helpful, and being able to compare both kinds even more so. ;) |
Member
Author
|
@addaleax Using current master: Success: https://gist.github.com/Trott/e32e1a48c84a9fdba09177e90bda05d4 Failure: https://gist.github.com/Trott/fb77e052ff369e33d1b18f5ad9492ba9 (terminated with cntl-c after it hung for a while, if that matters) |
Member
Author
|
Landed in 28a47aa |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2017
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess PR-URL: nodejs#14780 Fixes: nodejs#14747 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess PR-URL: #14780 Fixes: #14747 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, the parent process might not receive a message if it
is sent to soon, and then subsequent messages are also sometimes not
received.
(Is this a bug or expected operating system behavior like the
way a file watcher is returned before it's actually watching the file
system on/ macOS?)
Send a second message after a delay on macOS.
While at it, minor refactoring to the test:
commonmodule per test-writing guideFixes: #14747
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster