tools: update GYP to 324dd166 by refack · Pull Request #14718 · nodejs/node

refack · 2017-08-09T18:56:15Z

vendor these new commits

SHA	message
324dd16	gyp: show descriptive Windows SDK detection error by Jaime Bernardo
4801a53	gyp: update xml string encoding conversion by Refael Ackermann
d61a939	mac_tool.py: Handle non-zero ibtool return code. by Michail Pishchagin
a478c1a	win: mkdir even when copying directory by Refael Ackermann
ffd524c	win ninja/make: Always use a native compiler executable with MSVS 2017 by Mark Mentovai
e885024	Fix MSVC++ 32-on-32 builds after b62d04ff85e6 by Mark Mentovai
8dc7724	Disable flaky test/copies/gyptest-all under msvs. by Dirk Pranke
b62d04f	win,ninja: ninja generator better on windows by Refael Ackermann
ae76d91	Clean up gyptest.py. by Dirk Pranke
`a94b02e`	Disable a bunch of tests on Mac. by Dirk Pranke
19495aa	Update test/no-cpp/gyptest-no-cpp. by Dirk Pranke

Then refloat:

Autor	Message	SHA
shigeki	gyp: fix gyp to work on MacOSX without XCode	3681071
jbergstroem	gyp: inherit parent for `*.host`	d50702d
bnoordhuis	gyp: add compile_commands.json gyp generator	fa3220d
danbev	gyp: enable cctest to use objects (gyp part)	649ab2b
danbev	gyp: fix ninja build failure (GYP patch)	4c22050
sam-github	gyp: implement LD/LDXX for ninja and FIPS	`8d96a25`

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

tools,gyp

refack · 2017-08-09T18:59:04Z

/cc @nodejs/build @nodejs/python

refack · 2017-08-15T16:56:07Z

/cc @bnoordhuis @nodejs/platform-windows @nodejs/node-chakracore @JaneaSystems anyone feels like reviewing 🙌

refack · 2017-08-19T20:31:29Z

CI: https://ci.nodejs.org/job/node-test-commit/11909/
(only infra problems, but since this is build related, I want to see this build with FIPS and on maxOS)

Resumed: https://ci.nodejs.org/job/node-test-commit/11930/ ✔️

jasnell · 2017-08-23T20:19:15Z

CI is green.

refack · 2017-08-23T20:19:57Z

Landing

PR-URL: nodejs#14718 Refs: https://chromium.googlesource.com/external/gyp/+/324dd166b7c0b39d513026fa52d6280ac6d56770 Refs: refack/GYP3@324dd16 Reviewed-By: James M Snell <jasnell@gmail.com>

This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: nodejs#1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not suitable for environments that only uses the clang toolchain. Since we already assume that the user will provide clang/clang++ through CC/CXX, lean against it (then drop to gcc/g++). Also apply the same logic for link/ar for consistency although it doesn't affect us. PR-URL: nodejs#6173 Fixes: nodejs#6152 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

this is a re-base of the gyp part of 3c46bb9 after bumping GYP version to https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161 Original-Review-By: James M Snell <jasnell@gmail.com> Ref: nodejs#7986 PR-URL: nodejs#12450 Reviewed-By: João Reis <reis@janeasystems.com>

this is a re-base of the gyp part of 6a09a69 after bumping GYP version to https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161 Original-PR-URL: nodejs#11956 Original-Ref: nodejs#9163 Original-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#12450 Reviewed-By: João Reis <reis@janeasystems.com>

Currently the files specified in libraries in node.gyp `cctest` target are getting a '.lib' extension on windows when generated with ninja. This commit adds a check to see if a file has a '.obj' extension and in that case no '.lib' extension will be added. Also, the LIBS specified in the 'libraries' section are not being included in the --start-group --end-group section which means that these libraries will not be searched causing issue with linkers where the order matters. PR-URL: nodejs#12484 Fixes: nodejs#12448 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

The ability to set the link rule is used for FIPS, and needs to set both the `ld =` and `ldxx =` variables in the ninja build file to link c++ (node) and c (openssl-cli, etc.) executables. URL: nodejs#14227 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

refack · 2017-08-23T20:30:35Z

Landed in:
327077c
3debbc7
4cc7891
503916a
e78a79a
2550152
cbd3708

PR-URL: nodejs/node#14718 Refs: https://chromium.googlesource.com/external/gyp/+/324dd166b7c0b39d513026fa52d6280ac6d56770 Refs: refack/GYP3@324dd16 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #14718 Refs: https://chromium.googlesource.com/external/gyp/+/324dd166b7c0b39d513026fa52d6280ac6d56770 Refs: refack/GYP3@324dd16 Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-09-20T17:32:15Z

Should this be backported to v6.x? If so it may need to be done manually, have not yet checked

MylesBorins · 2017-10-16T22:09:19Z

ping @nodejs/build @nodejs/node-gyp

refack · 2017-10-16T22:24:24Z

Not critical. Mostly support for new OSes and platforms.

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Aug 9, 2017

refack requested review from addaleax, bnoordhuis and joaocgreis August 9, 2017 18:58

refack mentioned this pull request Aug 9, 2017

gyp: show descriptive Windows SDK detection error #14597

Closed

2 tasks

refack added the python PRs and issues that require attention from people who are familiar with Python. label Aug 15, 2017

jasnell approved these changes Aug 16, 2017

View reviewed changes

refack mentioned this pull request Aug 19, 2017

Bump gyp 19495aa nodejs/node-gyp#1183

Closed

2 tasks

refack force-pushed the gyp-bump-3 branch from 8d96a25 to ecda84c Compare August 19, 2017 19:20

refack self-assigned this Aug 19, 2017

refack and others added 7 commits August 23, 2017 16:24

tools: update GYP to 324dd166

327077c

PR-URL: nodejs#14718 Refs: https://chromium.googlesource.com/external/gyp/+/324dd166b7c0b39d513026fa52d6280ac6d56770 Refs: refack/GYP3@324dd16 Reviewed-By: James M Snell <jasnell@gmail.com>

refack force-pushed the gyp-bump-3 branch from ecda84c to cbd3708 Compare August 23, 2017 20:26

refack merged commit cbd3708 into nodejs:master Aug 23, 2017

MylesBorins mentioned this pull request Sep 10, 2017

v8.5.0 proposal #15308

Merged

refack deleted the gyp-bump-3 branch September 18, 2017 01:10

MylesBorins added the lts-watch-v6.x label Sep 20, 2017

refack added dont-land-on-v4.x and removed lts-watch-v6.x labels Oct 16, 2017

refack removed their assignment Oct 12, 2018

DeeDeeG mentioned this pull request May 14, 2021

Upstream gyp has actually been updated somewhat recently. Review those changes and sync (some of) them? nodejs/gyp-next#108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: update GYP to 324dd166#14718

tools: update GYP to 324dd166#14718
refack merged 7 commits intonodejs:masterfrom
refack:gyp-bump-3

refack commented Aug 9, 2017 •

edited

Loading

Uh oh!

refack commented Aug 9, 2017

Uh oh!

refack commented Aug 15, 2017

Uh oh!

refack commented Aug 19, 2017 •

edited

Loading

Uh oh!

jasnell commented Aug 23, 2017

Uh oh!

refack commented Aug 23, 2017

Uh oh!

refack commented Aug 23, 2017

Uh oh!

MylesBorins commented Sep 20, 2017

Uh oh!

MylesBorins commented Oct 16, 2017

Uh oh!

refack commented Oct 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

refack commented Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

refack commented Aug 9, 2017

Uh oh!

refack commented Aug 15, 2017

Uh oh!

refack commented Aug 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Aug 23, 2017

Uh oh!

refack commented Aug 23, 2017

Uh oh!

refack commented Aug 23, 2017

Uh oh!

MylesBorins commented Sep 20, 2017

Uh oh!

MylesBorins commented Oct 16, 2017

Uh oh!

refack commented Oct 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

refack commented Aug 9, 2017 •

edited

Loading

refack commented Aug 19, 2017 •

edited

Loading