async_hooks: CHECK that resource is not empty#14694
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
async_hooks: CHECK that resource is not empty#14694addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
the
async_hooks
nodejs-github-bot
added
async_wrap
c++
cjihrig
approved these changes
Aug 8, 2017
bnoordhuis
approved these changes
Aug 8, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Maybe also do it for type.
This condition can be triggered through the public C++ embedder API.
addaleax
force-pushed
the
async-hooks-check-resource
branch
from
2868276 to
35cb4af
Compare
Member
Author
|
@bnoordhuis Done, although I’m less worried about that because that code path wouldn’t reachable from public APIs, I think. |
refack
approved these changes
Aug 8, 2017
tniessen
approved these changes
Aug 9, 2017
Member
Author
|
Landed in 66fd78e |
addaleax
added a commit
that referenced
this pull request
Aug 10, 2017
This condition can be triggered through the public C++ embedder API. PR-URL: #14694 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
added a commit
that referenced
this pull request
Aug 10, 2017
This condition can be triggered through the public C++ embedder API. PR-URL: #14694 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
added
the
baking-for-lts
MylesBorins
removed
the
baking-for-lts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This condition can be triggered through the public C++ embedder API, so check for it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks