[v8.x backport] test: refactor test/sequential/test-fs-watch.js#14575
Closed
Trott wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x backport] test: refactor test/sequential/test-fs-watch.js#14575Trott wants to merge 1 commit intonodejs:v8.x-stagingfrom
Trott wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide PR-URL: nodejs#14534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2 tasks
addaleax
approved these changes
Aug 1, 2017
Member
|
Landed in ce9e3cf, thanks! |
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide Backport-PR-URL: #14575 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #14534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #14534
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)