lib: repl add .load-editor feature

[robbinhan]

support input .load-editor in repl

[Fishrock123]

Needs docs.

Should be added under https://github.com/nodejs/node/blob/master/doc/api/repl.md#commands-and-special-keys

[Fishrock123]

Maybe 'Load a file and enter editor mode'?

[XadillaX]

Would you please update your summary to describe your PR?

eg.

repl: fix .... (not an issue number but describe what exactly you have done)

[XadillaX]

any reason to have these modification? (a blank line and some spaces)

[robbinhan]

because add .load-editor command need more space for fomat

> .help
.break         Sometimes you get stuck, this gets you out
.clear         Break, and also clear the local context
.editor        Enter editor mode
.exit          Exit the repl
.help          Print this help message
.load          Load JS from a file into the REPL session
.load-editor   Load a file and enter editor mode
.save          Save all evaluated commands in this REPL session to a file
.say1          help for say1
.say2
>

[XadillaX]

👌

[Trott]

Thanks for this! It would seem that it needs a test.

[XadillaX]

How about this blank line?

[robbinhan]

@Fishrock123 I updated doc
@Trott I added a test
@XadillaX I removed it

test added, dismissing review

docs added

[jasnell]

It would be helpful to have an example

[robbinhan]

Do you mean add an example in doc?

[jasnell]

Yeah. For instance, I presume there's a way of providing the file name to load but that's not captured here

[Fishrock123]

Just how .load does it should be fine, the second line.

[robbinhan]

Thanks, I have updated doc file

[jasnell]

stream.write = common.mustNotCall('writing not allowed');

[robbinhan]

thank you for your help

[Fishrock123]

CI: https://ci.nodejs.org/job/node-test-pull-request/9686/

[lance]

In #14861 (comment) I discovered that .load will only work with some .js files, but not all depending on the formatting. I wonder if it makes more sense to just have .load capable of loading and executing any JS file, vs having it work for some but not all. I'm not sure the benefit of adding additional surface area to the REPLServer interface with .load-editor when .load itself should be improved (imo).

[robbinhan]

@lance
In my opinion, these are two different command. ‘.load’ just a command to lad file, and does’t do more things rather than that. ‘.load-editor’ means that load file and change into editor mode.

[lance]

@robbinhan I see your point. But it seems to me that, as-is, .load is broken and should be fixed. A reasonable fix for it would be to enable editor mode when .load is executed. In doing that, there is no need for .load-editor.

As I said in my PR, I didn't mean to encroach on what you were doing here, I was just trying to address #14022. I wasn't aware of your PR until a comment from @Fishrock123. I definitely appreciate your contribution here, and I am willing to go with whatever approach makes the most sense. In this case, I feel it's fixing .load, but I will defer to others' opinions.

[robbinhan]

@lance So, does improve .load command to enable editor mode, than remove .load-editor command is the best choice？

[lance]

@robbinhan in my opinion, yes. But I want to hear from other @nodejs/collaborators on it.

[jasnell]

I'm thinking that the other PR is likely the better option. Not quite ready to sign off on it tho.

[BridgeAR]

I looked at both of these and I am definitely in favor of #14861. As @lance already pointed out it is more like a bug fix instead of adding a new feature. .load is simply not working as it is intended to and #14861 fixes that. Because of those reasons I am actually opposed to landing this.

@robbinhan I appreciate your work a lot nevertheless!

[BridgeAR]

Closing due to the already mentioned reasons.