build: add NetBSD support to opensslconf.h#14313
Closed
rsmarples wants to merge 1 commit intonodejs:masterfrom
Closed
build: add NetBSD support to opensslconf.h#14313rsmarples wants to merge 1 commit intonodejs:masterfrom
rsmarples wants to merge 1 commit intonodejs:masterfrom
Conversation
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation.
nodejs-github-bot
added
the
openssl
Contributor
|
Shouldn't this be submitted upstream instead? |
Contributor
Author
|
The comments inside this file imply it's maintained by node? Or is that wrong? |
Member
|
Upstream openssl generates it at build time. We have a pregenerated version for convenience. The define leaks out though because opensslconf.h is included in many places. That includes native add-ons that build against the bundled openssl. |
Contributor
Author
|
It seems that upstream just have a BSD-generic64 configure target - they don't have any specific test for FreeBSD or OpenBSD that's missing for NetBSD to generate opensslconf.h as far as I can tell. |
bnoordhuis
approved these changes
Jul 16, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Okay, seems fine if this is all that's needed. Thanks.
As to my comment on the define leaking out, I realize it's not materially different from the existing OPENSSL_LINUX define so objection withdrawn.
rsmarples
added a commit
to rsmarples/nodegit
that referenced
this pull request
Aug 5, 2017
my node commit: a6fe49b9bdedef513f67009f4de665492d2d3012 upstream PR: nodejs/node#14313
Member
|
@bnoordhuis I guess this could land? |
Member
|
Landed in 0b0c2ec |
BridgeAR
pushed a commit
that referenced
this pull request
Aug 30, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: #14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: nodejs#14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: nodejs/node#14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: #14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: #14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 20, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: #14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 26, 2017
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: #14313 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the BSD list by defining OPENSSL_BSD if using a matching
BSD platform.
Add NetBSD to the list and update documentation.
make -j4 test(UNIX)