repl: handle null thrown by benjamingr · Pull Request #14306 · nodejs/node

benjamingr · 2017-07-16T15:59:18Z

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

repl

Fixes #12373

benjamingr · 2017-07-16T16:00:44Z

test/parallel/test-repl-sigint.js

TimothyGu · 2017-07-17T07:14:46Z

lib/repl.js

Well, things that are thrown aren't necessarily always errors. Maybe Thrown: or just ${e}\n?

(Also does this work with symbols?)

@TimothyGu I preferred to make the smaller changed - for it to work with symbols we'd need to wrap it in String (I can do that).

I can change the terminology from Error: to Thrown: I was hoping we could get a little bikeshedding on the message.

Yeah well, this kinda goes back to #13784, which is still in limbo because of the lack of a good way to stringify an object.

@TimothyGu yes, but I think String is a good middle ground - I don't want it to be bulletproof - I want it to be useful for users.

TimothyGu · 2017-07-17T07:48:54Z

lib/repl.js

Yeah well, this kinda goes back to #13784, which is still in limbo because of the lack of a good way to stringify an object.

TimothyGu · 2017-07-17T07:49:06Z

test/parallel/test-repl-null-thrown.js

Is the process.nextTick necessary?

@TimothyGu yes, to reproduce the issue - without the nextTick it doesn't crash the REPL.

Previous behavior was to assume an error is a proper error in the repl module. A check was added to not terminate the process on thrown repl errors that are `null` or `undefined`. PR-URL: nodejs#14306 Fixes: nodejs#12373 Reviewed-By: Anna Henningsen <anna@addaleax.net>

benjamingr · 2017-07-17T08:19:32Z

@TimothyGu renamed "Error: " to "Thrown: " and handled thrown symbols.

TimothyGu

LGTM.

TimothyGu · 2017-07-17T09:17:48Z

lib/repl.js

    const top = replMap.get(self);
+
    internalUtil.decorateErrorStack(e);
+    const isError = internalUtil.isError(e);


Why not process.binding('util').isNativeError?

@TimothyGu Not sure that's the behaviour I'd want - I'd like people to (optimally) be able to override Symbol.toStringTag (or even the name) and take the "Error like" path if they really need to.

I don't feel strongly about this though. If you do - let me know and I'll change it.

Sounds good to me.

jasnell · 2017-07-17T16:30:50Z

test/parallel/test-repl-null-thrown.js

+replserver.emit('line', '.exit');
+
+setTimeout(() => {
+  console.log(text);


extraneous console.log() output?

Fishrock123

CI: https://ci.nodejs.org/job/node-test-pull-request/9200/

cjihrig

LGTM. I am curious why people aren't asking for all of the obnoxious scenarios from #12400 though :-D

TimothyGu · 2017-07-18T00:57:48Z

I mean, we can still craft weird scenarios with @@toStringTag, @@toPrimitive, valueOf, toString, stack, Proxys, etc. I know I've fallen into the traps of bikeshedding before (sorry @cjihrig), but this seems like as KISS of a threshold as any. And I guess the user deserves to get some weird error if they does one or more of those things.

TimothyGu · 2017-07-19T06:35:13Z

Landed in 380e814.

benjamingr · 2017-07-19T06:36:11Z

@TimothyGu note: you landed this without passing CI (last CI was failing due to changed error message). I've started a CI in https://ci.nodejs.org/job/node-test-pull-request/9246/console

TimothyGu · 2017-07-19T06:36:53Z

@benjamingr I didn't land this BTW, I just noticed it was landed w/o a "landed" comment.

benjamingr · 2017-07-19T06:38:41Z

@TimothyGu I landed and immediately force reverted because of the CI (and posted in #node-dev) - currently waiting for CI to land this.

TimothyGu · 2017-07-19T06:39:50Z

@benjamingr Ah oops. Sorry, should've let you handle this (and checked IRC...)

benjamingr · 2017-07-19T09:17:45Z

ARM fanned failure on inspector/test-inspector-port-cluster unrelated.

benjamingr · 2017-07-19T09:21:02Z

Landed in 030a028 🎉

Previous behavior was to assume an error is a proper error in the repl module. A check was added to not terminate the process on thrown repl errors that are `null` or `undefined`. PR-URL: #14306 Fixes: #12373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com

MylesBorins · 2017-08-16T07:35:44Z

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

MylesBorins · 2017-12-19T17:35:41Z

ping @benjamingr

MylesBorins · 2018-01-11T18:13:22Z

ping @benjamingr

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Jul 16, 2017

benjamingr commented Jul 16, 2017

View reviewed changes

test/parallel/test-repl-sigint.js Outdated

Copy link

Member Author

benjamingr Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

addaleax approved these changes Jul 17, 2017

View reviewed changes

benjamingr mentioned this pull request Jul 17, 2017

REPL crashes after let process; #6802

Closed

TimothyGu reviewed Jul 17, 2017

View reviewed changes

benjamingr force-pushed the repl-handle-null-thrown branch from 3200c5a to 4dfe7fd Compare July 17, 2017 08:18

TimothyGu approved these changes Jul 17, 2017

View reviewed changes

jasnell reviewed Jul 17, 2017

View reviewed changes

Fishrock123 approved these changes Jul 17, 2017

View reviewed changes

cjihrig approved these changes Jul 17, 2017

View reviewed changes

Update test

64ecdf0

TimothyGu closed this Jul 19, 2017

benjamingr reopened this Jul 19, 2017

benjamingr closed this Jul 19, 2017

addaleax mentioned this pull request Jul 24, 2017

v8.3.0 proposal #14452

Closed

addaleax mentioned this pull request Aug 2, 2017

v8.3.0 proposal #14594

Merged

MylesBorins added the lts-watch-v6.x label Aug 16, 2017

IonicaBizau mentioned this pull request Oct 27, 2017

throw null and throw undefined crash in repl #16545

Closed

Uh oh!

Conversation

benjamingr commented Jul 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected core subsystem(s)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjamingr commented Jul 17, 2017

Uh oh!

TimothyGu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fishrock123 left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

TimothyGu commented Jul 18, 2017

Uh oh!

TimothyGu commented Jul 19, 2017

Uh oh!

benjamingr commented Jul 19, 2017

Uh oh!

TimothyGu commented Jul 19, 2017

Uh oh!

benjamingr commented Jul 19, 2017

Uh oh!

TimothyGu commented Jul 19, 2017

Uh oh!

benjamingr commented Jul 19, 2017

Uh oh!

benjamingr commented Jul 19, 2017

Uh oh!

MylesBorins commented Aug 16, 2017

Uh oh!

MylesBorins commented Dec 19, 2017

Uh oh!

MylesBorins commented Jan 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

benjamingr commented Jul 16, 2017 •

edited

Loading