doc: update configure to require g++ 4.9.4#14204
Closed
cxreg wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
build
addaleax
approved these changes
Jul 12, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM
I’m okay with not letting this wait 48 hours.
refack
approved these changes
Jul 12, 2017
Contributor
|
+1 on expedition |
Contributor
|
Quick test on linuxONE: https://ci.nodejs.org/job/node-test-commit-linuxone/7247/ |
Member
|
I think a run to validate we have the compiler across all machines makes sense as well. CI does not seem to have much of a backlog right now. |
Member
|
Will this actually fail to build or just generate a warning ? |
bnoordhuis
approved these changes
Jul 13, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM
@mhdawson Prints a warning.
Member
|
@bnoordhuis thats what I thought, I guess running the CI across platforms will not necessarily tell us if we've upgraded them all or not. |
tniessen
approved these changes
Jul 31, 2017
jasnell
approved these changes
Jul 31, 2017
BridgeAR
approved these changes
Aug 28, 2017
Member
|
Landed in 79773f8 |
BridgeAR
pushed a commit
that referenced
this pull request
Aug 28, 2017
PR-URL: #14204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #14204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #14204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d13a65a bumped the g++ requirement to 4.9.4 but configure is not enforcing it. Update configure to correctly detect this.
/cc @nodejs/build
Checklist