test: fix failure in test-icu-data-dir.js#13987
test: fix failure in test-icu-data-dir.js#13987tniessen wants to merge 3 commits intonodejs:masterfrom
Conversation
PR broke tests on Windows. Ref: nodejs#13940
|
Can you use the default revert commit message? It should look something like |
|
Wouldn't it be better to just fix the tests? |
I will check whether using |
|
@mscdex PTAL |
|
As long as it passes CI it's fine by me. |
|
It appears this already landed in a1ecdcf. |
|
Landed in a1ecdcf. Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/10072/ @mscdex Yes, I pushed it seconds ago, after going through all the CI failures and making sure they were unrelated. (I just rebased it an hour ago, I didn't land it back then.) |
This fixes a broken test on Windows caused by EOL conversion. PR-URL: #13987 Refs: #13940 Refs: #13986 Reviewed-By: Refael Ackermann <[email protected]>
This fixes a broken test on Windows caused by EOL conversion. PR-URL: #13987 Refs: #13940 Refs: #13986 Reviewed-By: Refael Ackermann <[email protected]>
This fixes a broken test on Windows caused by EOL conversion. PR-URL: #13987 Refs: #13940 Refs: #13986 Reviewed-By: Refael Ackermann <[email protected]>
PR #13940 broke tests on Windows.
Ref: #13986
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src