child_process: remove nextTick on IPC message#13648
Closed
mscdex wants to merge 1 commit intonodejs:masterfrom
Closed
child_process: remove nextTick on IPC message#13648mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex wants to merge 1 commit intonodejs:masterfrom
Conversation
213a261 to
def344b
Compare
Member
|
The problem I see is that an exception in a user's 'message' listener throws a wrench in the |
Contributor
Author
|
@bnoordhuis Wouldn't that be the case in general, no matter if each message was |
3 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jun 24, 2017
This commit fixes a regression related to IPC 'message' events. When messages are not emitted in the next tick, a 'message' handler that throws can break the IPC read loop. Refs: nodejs#6909 Refs: nodejs#13459 Refs: nodejs#13648 PR-URL: nodejs#13856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
This commit fixes a regression related to IPC 'message' events. When messages are not emitted in the next tick, a 'message' handler that throws can break the IPC read loop. Refs: #6909 Refs: #13459 Refs: #13648 PR-URL: #13856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
This commit fixes a regression related to IPC 'message' events. When messages are not emitted in the next tick, a 'message' handler that throws can break the IPC read loop. Refs: #6909 Refs: #13459 Refs: #13648 PR-URL: #13856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
This commit fixes a regression related to IPC 'message' events. When messages are not emitted in the next tick, a 'message' handler that throws can break the IPC read loop. Refs: #6909 Refs: #13459 Refs: #13648 PR-URL: #13856 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #13459 which avoided all but the first
nextTick()on receipt of non-internal IPC messages. The reason for that was I just wanted to be more cautious in that PR. This PR however removesnextTick()entirely as messages should always be received on future tick(s) anyway, so there shouldn't be any issues with user event handlers being executed immediately after callingfork(), etc.Benchmark results:
CI: https://ci.nodejs.org/job/node-test-pull-request/8621/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)