doc: update async_hooks providers list#13561
Conversation
doc/api/async_hooks.md
Outdated
There was a problem hiding this comment.
I know it was there before but probably should to call -> to be called
Less sure but maybe correspond -> correlate
Correspond: have a close similarity; match or agree almost exactly.
Correlate: have a mutual relationship or connection, in which one thing affects or depends on another.
There was a problem hiding this comment.
I know it was there before but probably should
to call->to be called
Ah right, done.
Correspond: have a close similarity; match or agree almost exactly.
Well, that’s basically exactly what it’s supposed to say, so it seems like choosing correspond is perfect. :)
|
Don't agree with this changed for same reasons stated in #13452 (comment). Users should know what they can filter for from node core, and should also be able to find the same in documentation from module authors that create their own types. |
|
@nodejs/async_hooks … I don’t have terribly strong feelings either way. |
|
Why not update this rather than remove it? 😕 |
|
Should we just expose |
e9178fe to
a9eb903
Compare
|
@trevnorris @Fishrock123 Seems like I misread the discussion in #13452 a bit. I’ve updated this to add |
doc/api/async_hooks.md
Outdated
There was a problem hiding this comment.
Shouldn't Timeout and Immediate be uppercase or no?
There was a problem hiding this comment.
No, these values are emitted from JS and are written this way in the source code.
There was a problem hiding this comment.
It may be worth adding a note to point that out ... specifically, the all-caps ones come from native code while the mixed case come from JavaScript
There was a problem hiding this comment.
Don't forget TickObject! 😄
a9eb903 to
4bbad95
Compare
I'm down for that, but please expose it as |
Ref: #13610 |
|
Landed in 0ab4614 |
Ref: #13452
Checklist
Affected core subsystem(s)
doc/async_hooks