doc: fix napi_create_*_error signatures in n-api#13544
Closed
jamen wants to merge 1 commit intonodejs:masterfrom
jamen:create_error_signatures
Closed
doc: fix napi_create_*_error signatures in n-api#13544jamen wants to merge 1 commit intonodejs:masterfrom jamen:create_error_signatures
jamen wants to merge 1 commit intonodejs:masterfrom
jamen:create_error_signatures
Conversation
nodejs-github-bot
added
doc
addaleax
approved these changes
Jun 8, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Thank you for noticing!
Can you try to wrap the lines at 80 characters? We try to align the arguments vertically for cases like these, compare e.g. napi_is_error.
Contributor
Author
|
Done. |
cjihrig
approved these changes
Jun 8, 2017
jasongin
approved these changes
Jun 8, 2017
jasnell
approved these changes
Jun 9, 2017
Member
|
Going to land this |
benjamingr
pushed a commit
that referenced
this pull request
Jun 10, 2017
PR-URL: #13544 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna M. Kedzierska <anna.m.kedzierska@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Member
|
Demonstrated to someone in Node how the process works :) Thanks. |
Member
|
@benjamingr By the way, you accidentally pushed d62de929a7b464602466317c0ba596e56180237f as well – I just force-pushed it out, but I’m mentioning it just so you know you’ll want to rewind your master branch as well :) (Thanks to @lpinca for noticing it in IRC.) |
Member
|
Oh, and by the way, you |
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
PR-URL: #13544 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna M. Kedzierska <anna.m.kedzierska@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Member
|
So sorry, not used for people watching me :O |
Merged
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#13544 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna M. Kedzierska <anna.m.kedzierska@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that these signatures need the
napi_value* resultof the error they are creating (as described below each one, and earlier in the docs)Checklist
Affected core subsystem(s)