v8: add a js class for Serializer/Dserializer by zimbabao · Pull Request #13541 · nodejs/node

zimbabao · 2017-06-08T08:50:03Z

Calling Serializer/Deserlizer without new crashes node.
Adding a js class which just inherits cpp bindings.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes (test failing on master too)
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Fixes: nodejs#13326

bnoordhuis · 2017-06-08T09:00:48Z

Can you add some regression tests?

There were some gotchas around new.target and native code but I forgot the details. It would be interesting to see if class S extends v8.Serializer works and what instance.method.call({}) does.

I expect it throws an 'illegal invocation' exception but it would be good to verify that.

addaleax · 2017-06-08T09:02:26Z

interesting to see if class S extends v8.Serializer works

It does, we already extend it :)

bnoordhuis · 2017-06-08T09:05:00Z

I mean when you extend the class that this PR introduces.

TimothyGu · 2017-06-08T09:37:51Z

@bnoordhuis, the classes this PR introduces are already extended further down the file by DefaultSerializer and DefaultDeserializer.

bnoordhuis · 2017-06-08T09:54:48Z

Okay. Regression tests for the other issues would still be good though.

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Fixes: nodejs#13326

zimbabao · 2017-06-08T16:38:03Z

@bnoordhuis : Added regression tests.

cjihrig · 2017-06-08T16:39:25Z

test/parallel/test-v8-serdes.js

 }
+
+{
+  try {


Can you use assert.throws() for these.

@cjihrig : Made suggested changes.

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Added refression tests. Fixes: nodejs#13326

cjihrig · 2017-06-08T17:23:23Z

test/parallel/test-v8-serdes.js

+      v8.Serializer();
+    },
+    Error,
+    "Class constructor Serializer cannot be invoked without 'new'"


Can you do something more like this:

assert.throws( () => { v8.Serializer(); }, /^Error: Class constructor Serializer cannot be invoked without 'new'$/ );

@cjihrig : Done

mscdex · 2017-06-08T19:23:51Z

There are typos in the commit message(s): s/Dserializer/Deserializer/

zimbabao · 2017-06-08T20:55:42Z

@mscdex : Thanks, fixed

zimbabao · 2017-06-08T20:57:59Z

Can somebody fire a CI job for this.

mscdex · 2017-06-08T23:08:59Z

s/refression/regression/ in commit message(s) too.

CI: https://ci.nodejs.org/job/node-test-pull-request/8573/

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

zimbabao · 2017-06-08T23:21:53Z

@mscdex : Fixed on top review.

mscdex · 2017-06-09T00:13:14Z

CI again: https://ci.nodejs.org/job/node-test-pull-request/8574/

addaleax

Still LGTM

jasnell · 2017-06-09T17:22:35Z

lib/v8.js


+class Serializer extends serdesBindings.Serializer {}
+
+class Deserializer extends serdesBindings.Deserializer {}


I'd prefer something like:

const { Serializer: _Serializer, Deserializer: _Deserializer } = process.binding('serdes'); // ... class Serializer extends _Serializer { } class Deserializer extends _Deserializer { }

Will resend.

@jasnell : Made changes and added a note.

jasnell · 2017-06-09T17:24:01Z

test/parallel/test-v8-serdes.js

+    () => { v8.Deserializer(); },
+    /^TypeError: Class constructor Deserializer cannot be invoked without 'new'$/
+  );
+}


Should likely also add a note to the documentation clarifying the requirement

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

TimothyGu · 2017-06-10T00:12:54Z

lib/v8.js

 const { Buffer } = require('buffer');
-const { Serializer, Deserializer } = process.binding('serdes');
+const {
+        Serializer: _Serializer,


Can you indent two spaces only?

Done. BTW jslint didn't catch that error. May be we should add a rule?

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

TimothyGu · 2017-06-10T09:38:37Z

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/8588/

zimbabao · 2017-06-10T20:05:55Z

Tests pass on my mac osx sierra laptop. Above failures looks related to CI, can somebody start another run?.

addaleax · 2017-06-10T20:07:51Z

Yea, CI is a bit problematic right now, I’m not sure another run would solve much. This code isn’t platform-specific, though, so I think this is okay.

zimbabao · 2017-06-10T20:13:53Z

@addaleax : Thanks, anything else for landing this?.

addaleax · 2017-06-10T20:17:38Z

@zimbabao Our rules say that we’ll need to wait until tomorrow to land this, but nothing from your side I think. :)

refack

LGTM % docs

refack · 2017-06-10T20:33:50Z

arm: #13603
osx: #13527
linux: infrastructure fail https://ci.nodejs.org/job/node-test-commit-linux/10495/nodes=ubuntu1604_docker_alpine34-64/

addaleax · 2017-06-12T12:14:54Z

Landed in 12fd63d, thanks for the PR!

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: #13326 PR-URL: #13541 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fixes: nodejs#13326 Refs: nodejs#13541

Fixes: #13326 Refs: #13541 PR-URL: #36549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

v8: add a js class for Serializer/Dserializer

b39baec

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Fixes: nodejs#13326

addaleax approved these changes Jun 8, 2017

View reviewed changes

mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Jun 8, 2017

v8: add a js class for Serializer/Dserializer

90c50a6

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Fixes: nodejs#13326

cjihrig requested changes Jun 8, 2017

View reviewed changes

v8: add a js class for Serializer/Dserializer

e09951d

Calling Serializer/Deserlizer without new crashes node. Adding a js class which just inherits cpp bindings. Added refression tests. Fixes: nodejs#13326

cjihrig reviewed Jun 8, 2017

View reviewed changes

zimbabao force-pushed the fix-serlializer-crash branch from 88817fa to b72ec9c Compare June 8, 2017 18:25

cjihrig approved these changes Jun 8, 2017

View reviewed changes

zimbabao force-pushed the fix-serlializer-crash branch from b72ec9c to cfb934e Compare June 8, 2017 20:54

v8: add a js class for Serializer/Deserializer

9643c6c

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

zimbabao force-pushed the fix-serlializer-crash branch from cfb934e to 9643c6c Compare June 8, 2017 23:20

addaleax approved these changes Jun 9, 2017

View reviewed changes

jasnell reviewed Jun 9, 2017

View reviewed changes

v8: add a js class for Serializer/Deserializer

955a1bb

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

zimbabao force-pushed the fix-serlializer-crash branch from 47cccbe to 955a1bb Compare June 9, 2017 17:57

TimothyGu reviewed Jun 10, 2017

View reviewed changes

v8: add a js class for Serializer/Deserializer

1de429c

Calling Serializer/Deserializer without new crashes node. Adding a js class which just inherits cpp bindings. Added regression tests. Fixes: nodejs#13326

refack approved these changes Jun 10, 2017

View reviewed changes

addaleax closed this Jun 12, 2017

addaleax mentioned this pull request Jun 12, 2017

v8.1.1 proposal #13598

Merged

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

addaleax added dont-land-on-v4.x labels Jul 10, 2017

ExE-Boss mentioned this pull request Dec 17, 2020

v8: fix native serdes constructors #36549

Closed

3 tasks

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Dec 17, 2020

v8: Fix native serdes constructors

3a8ce4d

Fixes: nodejs#13326 Refs: nodejs#13541

addaleax pushed a commit that referenced this pull request Dec 22, 2020

v8: fix native serdes constructors

d90fa19

Fixes: #13326 Refs: #13541 PR-URL: #36549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 12, 2021

v8: fix native serdes constructors

3170636

Fixes: #13326 Refs: #13541 PR-URL: #36549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos pushed a commit that referenced this pull request May 1, 2021

v8: fix native serdes constructors

ba4788d

Fixes: #13326 Refs: #13541 PR-URL: #36549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

               }
+              {
+                try {


		class Serializer extends serdesBindings.Serializer {}

		class Deserializer extends serdesBindings.Deserializer {}

Uh oh!

Conversation

zimbabao commented Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

bnoordhuis commented Jun 8, 2017

Uh oh!

addaleax commented Jun 8, 2017

Uh oh!

bnoordhuis commented Jun 8, 2017

Uh oh!

TimothyGu commented Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis commented Jun 8, 2017

Uh oh!

zimbabao commented Jun 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mscdex commented Jun 8, 2017

Uh oh!

zimbabao commented Jun 8, 2017

Uh oh!

zimbabao commented Jun 8, 2017

Uh oh!

mscdex commented Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zimbabao commented Jun 8, 2017

Uh oh!

mscdex commented Jun 9, 2017

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TimothyGu commented Jun 10, 2017

Uh oh!

zimbabao commented Jun 10, 2017

Uh oh!

addaleax commented Jun 10, 2017

Uh oh!

zimbabao commented Jun 10, 2017

Uh oh!

addaleax commented Jun 10, 2017

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Jun 10, 2017

Uh oh!

addaleax commented Jun 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

zimbabao commented Jun 8, 2017 •

edited

Loading

TimothyGu commented Jun 8, 2017 •

edited

Loading

mscdex commented Jun 8, 2017 •

edited

Loading