Conversation
Member
|
Note that #13284 is coming...(or the other way around) |
joyeecheung
approved these changes
Jun 8, 2017
Contributor
Author
I know, it's my small way to congratulate you both 🎉 🎆 🍾 |
Trott
approved these changes
Jun 8, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. I don't think this needs to wait 48 hours.
tniessen
approved these changes
Jun 8, 2017
Contributor
|
Congratulations! |
Contributor
Author
|
@mcollina @joyeecheung , one of you want to do the honors? |
evanlucas
approved these changes
Jun 8, 2017
Fishrock123
approved these changes
Jun 8, 2017
Member
|
Landed as d958bf8 🎉 ! |
mcollina
pushed a commit
that referenced
this pull request
Jun 8, 2017
Ref: #12789 Ref: #12790 PR-URL: #13534 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
Ref: #12789 Ref: #12790 PR-URL: #13534 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Ref: #12789 Ref: #12790 PR-URL: #13534 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #12789
Ref: #12790
Checklist
Affected core subsystem(s)
doc