async_hooks: make sure .{en|dis}able() === this#13418
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
async_hooks: make sure .{en|dis}able() === this#13418addaleax wants to merge 1 commit intonodejs:masterfrom
.{en|dis}able() === this#13418addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Make sure that `hook.enable()` and `hook.disable()` return `hook` consistently, as the documentation indicates.
nodejs-github-bot
added
the
async_hooks
refack
approved these changes
Jun 2, 2017
AndreasMadsen
approved these changes
Jun 2, 2017
jasnell
approved these changes
Jun 4, 2017
cjihrig
approved these changes
Jun 4, 2017
trevnorris
approved these changes
Jun 6, 2017
Contributor
trevnorris
left a comment
trevnorris
left a comment
There was a problem hiding this comment.
Oops. Oversight on my part. Thanks for the fix + test.
Member
Author
Member
Author
|
Landed in 6318078 |
addaleax
added a commit
that referenced
this pull request
Jun 8, 2017
Make sure that `hook.enable()` and `hook.disable()` return `hook` consistently, as the documentation indicates. PR-URL: #13418 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
addaleax
added a commit
that referenced
this pull request
Jun 10, 2017
Make sure that `hook.enable()` and `hook.disable()` return `hook` consistently, as the documentation indicates. PR-URL: #13418 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that
hook.enable()andhook.disable()returnhookconsistently, as the documentation indicates.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks /cc @nodejs/async_hooks