doc: fix code examples in zlib.md#13342
doc: fix code examples in zlib.md#13342vsemozhetbyt wants to merge 3 commits intonodejs:masterfrom vsemozhetbyt:zlib.md
Conversation
nodejs-github-bot
added
doc
|
I am a bit confused about this fragment:
If there is a typo here, let me know how to fix it. |
|
@vsemozhetbyt I don’t think there’s a typo in there, but I’d be glad to work out better phrasing if you have ideas or questions? |
|
I think it's supposed to be 'compress' and not 'compressed' in that bolded sentence? |
|
Heh. 😄 Sorry, yes, that’s a typo. |
|
@addaleax This option is very briefly documented, so I cannot suggest what the right wording would be:
Is this a right grammar? What does it mean? |
|
Yeah, right, it should be |
|
@addaleax is right, it should be 'decompress' now that I read the surrounding context. |
|
LGTM |
* Use test() instead of match() in boolean context. * Add spaces in code example. * Fix typo. PR-URL: #13342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Landed in 6cfdbc7 |
* Use test() instead of match() in boolean context. * Add spaces in code example. * Fix typo. PR-URL: #13342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
9 participants
Checklist
Affected core subsystem(s)
doc, zlib
test()instead ofmatch()in boolean context.