errors,_stream_wrap: change _stream_wrap.js to use internal/errors.js

[LakshmiSwethaG]

Refs: #11273

@jasnell, pinging you for mentoring as this is my first PR to this project, thank you!

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows [commit guidelines]

Affected core subsystem(s)

_stream_wrap.js

[jasnell]

ERR_ASSERTION is the wrong code to use here. That should only be used with the assert module. I recommend creating a new code specific to this condition... perhaps ERR_STREAM_HAS_STRINGDECODER

[LakshmiSwethaG]

@jasnell , I followed your suggestions and made those changes.
In this process, I made few mistakes but I guess I recovered everything, please have a look.
Thanks.

[jasnell]

Just move the message to the internal/errors.js file where the code is declared, then simplify this to just:

self.emit('error', new errors.Error('ERR_STREAM_HAS_STRINGDECODER'));

[mhdawson]

Unfortunately this needs a rebase.

[LakshmiSwethaG]

Done the rebase and resolved the conflicts. Please review it. Thanks

[mhdawson]

CI run: https://ci.nodejs.org/job/node-test-pull-request/8690/

[tniessen]

Landed in d291338, thank you for your contribution! 🎉

[addaleax]

Labelled this semver-major as I think it should have been (not that there’s anything wrong with the patch), if I’m wrong feel free to remove the label.

[tniessen]

@addaleax The error message did not change, why would this be semver-major?

[addaleax]

@tniessen The error message changed from Error: Stream has StringDecoder to Error [ERR_STREAM_HAS_STRINGDECODER]: Stream has StringDecoder

[tniessen]

@addaleax Right, my bad.